From 909d61525ac9ea2592f04a66c27fac192a976354 Mon Sep 17 00:00:00 2001
From: Hadi <112569860+anotherhadi@users.noreply.github.com>
Date: Tue, 17 Mar 2026 00:04:06 +0100
Subject: [PATCH] Improvement, Fixes

Signed-off-by: Hadi <112569860+anotherhadi@users.noreply.github.com>
---
 src/components/Nav.svelte       |  9 +++++++--
 src/components/Result.svelte    | 14 ++------------
 src/components/SearchApp.svelte |  2 +-
 src/pages/api/search.ts         |  6 +++++-
 src/types/nav.ts                | 11 +++++++++++
 5 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/src/components/Nav.svelte b/src/components/Nav.svelte
index ddb7e0f..207c2b1 100644
--- a/src/components/Nav.svelte
+++ b/src/components/Nav.svelte
@@ -2,8 +2,13 @@
   import { Menu } from "lucide-svelte";
   import type { NavItem } from "../types/nav";
 
-  export let title: string = "";
-  export let navLinks: NavItem[] = [];
+  let {
+    title = "",
+    navLinks = [],
+  }: {
+    title?: string;
+    navLinks?: NavItem[];
+  } = $props();
 </script>
 
 <div class="bg-base-200">
diff --git a/src/components/Result.svelte b/src/components/Result.svelte
index 8a4f19c..1e00e5a 100644
--- a/src/components/Result.svelte
+++ b/src/components/Result.svelte
@@ -1,18 +1,8 @@
 <script lang="ts">
   import { User, Lock, Check, MessageCircle } from "lucide-svelte";
+  import type { Result } from "src/types/nav";
 
-  export interface Result {
-    manufacturer: string;
-    name: string;
-    icon: string;
-    tags: string[];
-    version: string;
-    comment: string;
-    user: string;
-    pass: string;
-  }
-
-  let { result }: { result: Result } = $props();
+  let { result }: { result: Result} = $props();
 
   let copiedUser = $state(false);
   let copiedPass = $state(false);
diff --git a/src/components/SearchApp.svelte b/src/components/SearchApp.svelte
index ae1a097..4c05c42 100644
--- a/src/components/SearchApp.svelte
+++ b/src/components/SearchApp.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
   import { onMount } from "svelte";
-  import type { Result as ResultType } from "./Result.svelte";
   import Result from "./Result.svelte";
+  import type { Result as ResultType } from "src/types/nav";
   import { Search } from "lucide-svelte";
   import DefaultView from "./DefaultView.svelte";
   import NotFoundView from "./NotFoundView.svelte";
diff --git a/src/pages/api/search.ts b/src/pages/api/search.ts
index 396dc35..0eda9c2 100644
--- a/src/pages/api/search.ts
+++ b/src/pages/api/search.ts
@@ -110,7 +110,11 @@ export const GET: APIRoute = async ({ url, request }) => {
     );
   }
 
-  // Server-side tracking for search queries, respecting DNT/GPC
+  // NOTE: Server-side tracking is intentionally only triggered when DNT/GPC is active.
+  // When DNT is off, the client handles tracking via Umami's JS snippet.
+  // When DNT is on, the JS snippet is suppressed, so we fall back to server-side tracking
+  // to log search queries (query string + result count only, no user data) in order to
+  // identify missing manufacturers/products and improve the dataset.
   if (query && dnt) {
     await trackSearchServerSide(query, filtered.length);
   }
diff --git a/src/types/nav.ts b/src/types/nav.ts
index 239e203..dfcc57a 100644
--- a/src/types/nav.ts
+++ b/src/types/nav.ts
@@ -4,3 +4,14 @@ export interface NavItem {
   icon?: any;
   children?: NavItem[];
 }
+
+export interface Result {
+  manufacturer: string;
+  name: string;
+  icon: string;
+  tags: string[];
+  version: string;
+  comment: string;
+  user: string;
+  pass: string;
+}